Re: [patch 06/16] Fix matroxfb on big-endian hardware

On Mon, May 23, 2005 at 04:22:07PM -0700, Chris Wright wrote:
> -				mga_writel(mmio, 0, *chardata);
> +#if defined(__BIG_ENDIAN)
> +				fb_writel((*chardata) << 24, mmio.vaddr);
> +#else
> +				fb_writel(*chardata, mmio.vaddr);
> +#endif

So basically you are passing it cpu_to_le32(*chardata)?

> +#if defined(__BIG_ENDIAN)
> +				fb_writel((*(u_int16_t*)chardata) << 16, mmio.vaddr);
> +#else
> +				fb_writel(*(u_int16_t*)chardata, mmio.vaddr);
> +#endif

*yuck*

cpu_to_le32(le16_to_cpu(*(__le16 *)chardata)?  Is that what you are doing
here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 06/16] Fix matroxfb on big-endian hardware
    • From: Chris Wright <[email protected]>

• References:
  • [00/16] -stable review
    • From: Chris Wright <[email protected]>
  • [patch 06/16] Fix matroxfb on big-endian hardware
    • From: Chris Wright <[email protected]>

• Prev by Date: ide-cd vs. DMA
• Next by Date: [patch 13/16] x86_64: Fix canonical checking for segment registers in ptrace
• Previous by thread: [patch 06/16] Fix matroxfb on big-endian hardware
• Next by thread: Re: [patch 06/16] Fix matroxfb on big-endian hardware
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]