Re: [RFC][PATCH] rbind across namespaces

[Ram <linuxram@us.ibm.com>]

On Sat, 2005-05-21 at 01:09, Miklos Szeredi wrote:
> > Enclosed the simplified patch,
> 
> Looks much better :)
> 
> I still see a problem: what if old_nd.mnt is already detached, and
> bind is non-recursive.  Now it fails with EINVAL, though it used to
> work (and I think is very useful).

I am not getting this comment.  R u assuming that a detached mount
will have NULL namespace?  If so I dont see it being the case.
Or am I missing some subtle point?


> When doing up_write(...) you don't have to keep the order, just check
> if the namespaces are not equal for the second up_write().

Yes. saves atleast 2 lines. 

> 
> And why don't you do this:
> 
> 	if (old_ns < mntpt_ns)
> 		down_write(&old_ns->sem);
> 
> instead of this
> 
> 	if (old_ns < mntpt_ns) {
> 		down_write(&old_ns->sem);
> 	}

Will do. Saves another few lines. :)

I will send out the new patch once I understand your first comment.
RP

> 
> Miklos

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/