On Fri, May 20, 2005 at 09:12:55AM +0200, Kay Sievers wrote:
> On Thu, 2005-05-19 at 09:43 -0700, Tom Rini wrote:
> > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > not a defined symbol. Trivial fix is to EXPORT_SYMBOL hotplug_path.
> >
> > Signed-off-by: Tom Rini <[email protected]>
> >
> > Index: lib/kobject_uevent.c
> > ===================================================================
> > --- c7d7a187a2125518e655dfeadffd38156239ffc3/lib/kobject_uevent.c (mode:100644)
> > +++ uncommitted/lib/kobject_uevent.c (mode:100644)
> > @@ -21,6 +21,7 @@
> > #include <linux/string.h>
> > #include <linux/kobject_uevent.h>
> > #include <linux/kobject.h>
> > +#include <linux/module.h>
> > #include <net/sock.h>
> >
> > #define BUFFER_SIZE 1024 /* buffer for the hotplug env */
> > @@ -178,6 +179,7 @@
> >
> > #ifdef CONFIG_HOTPLUG
> > char hotplug_path[HOTPLUG_PATH_LEN] = "/sbin/hotplug";
> > +EXPORT_SYMBOL(hotplug_path);
> > u64 hotplug_seqnum;
> > static DEFINE_SPINLOCK(sequence_lock);
>
> Please don't export it again. We're on the way to make it private.
> Nobody should ever have access to it outside of the driver core. The
> input layer event stuff is completely broken and we are already working
> on fixing this to use the driver core instead of calling /sbin/hotplug,
> which is completely nonsense these days.
So Greg said he's ACK this since the "make it private" stuff isn't done
yet. Will this go in or no?
--
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
