Re: [PATCH] kernel <linux-2.6.11.10> kernel/sched.c

[Con Kolivas <kernel@kolivas.org>]

On Fri, 20 May 2005 19:49, Ingo Molnar wrote:
> * chen Shang <shangcs@gmail.com> wrote:
> > I minimized my patch and against to 2.6.12-rc4 this time, see below.
>
> looks good - i've done some small style/whitespace cleanups and renamed
> prio to old_prio, patch against -rc4 below.

We should inline requeue_task as well.

Con
----

Putting requeue_task into the common fast path code in schedule() will
benefit generically from inlining the requeue_task function.

Signed-off-by: Con Kolivas <kernel@kolivas.org>

Index: linux-2.6.12-rc4/kernel/sched.c
===================================================================
--- linux-2.6.12-rc4.orig/kernel/sched.c	2005-05-20 20:28:29.000000000 +1000
+++ linux-2.6.12-rc4/kernel/sched.c	2005-05-20 20:28:55.000000000 +1000
@@ -560,7 +560,7 @@ static void enqueue_task(struct task_str
  * Put task to the end of the run list without the overhead of dequeue
  * followed by enqueue.
  */
-static void requeue_task(struct task_struct *p, prio_array_t *array)
+static inline void requeue_task(struct task_struct *p, prio_array_t *array)
 {
 	list_move_tail(&p->run_list, array->queue + p->prio);
 }

Attachment: pgpil1DJJQFAf.pgp
Description: PGP signature