[PATCH 2.4] random poolsize sysctl fix

Hello Marcelo,

SWSoft Linux kernel Team has discovered that your patch http://linux.bkbits.net:8080/linux-2.4/gnupatch@41e2c4fetTJmVti-Xxql21xXjfbpag which should fix a random poolsize sysctl handler integer overflow, is wrong. You have changed a variable definition in function proc_do_poolsize(), but you had to fix an another function, poolsize_strategy()

Vasily Averin
SWSoft Linux kernel Team

--- ./drivers/char/random.c.rndps	Wed Jan 19 17:09:48 2005
+++ ./drivers/char/random.c	Fri May 20 09:09:18 2005
@@ -1771,7 +1771,7 @@ static int change_poolsize(int poolsize)
 static int proc_do_poolsize(ctl_table *table, int write, struct file *filp,
 			    void *buffer, size_t *lenp)
 {
-	unsigned int	ret;
+	int	ret;
 
 	sysctl_poolsize = random_state->poolinfo.POOLBYTES;
 
@@ -1787,7 +1787,7 @@ static int poolsize_strategy(ctl_table *
 			     void *oldval, size_t *oldlenp,
 			     void *newval, size_t newlen, void **context)
 {
-	int	len;
+	unsigned int	len;
 	
 	sysctl_poolsize = random_state->poolinfo.POOLBYTES;
 

---

• Follow-Ups:
  • Re: [PATCH 2.4] random poolsize sysctl fix
    • From: Marcelo Tosatti <[email protected]>

• Prev by Date: Re: How start in Kernel Development
• Next by Date: Re: kbuild: specifying phony targets?
• Previous by thread: module mismatch
• Next by thread: Re: [PATCH 2.4] random poolsize sysctl fix
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]