Re: [PATCH] prevent NULL mmap in topdown model

On Wed, 18 May 2005, Rik van Riel wrote:
>
> On Wed, 18 May 2005, Linus Torvalds wrote:
> 
> > Why not just change the "addr >= len" test into "addr > len" and be done 
> > with it?
> 
> If you're fine with not catching dereferences of a struct
> member further than PAGE_SIZE into a struct when the struct
> pointer is NULL, sure ...

I'm certainly ok with that, especially since it should never be a problem
in practice (ie the virtual memory map getting so full that we even get to
these low allocations should be basically something that never happens
under normal load).

However, it would be good to have even the trivial patch tested. 
Especially since what it tries to fix is a total corner-case in the first 
place..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] prevent NULL mmap in topdown model
    • From: Chris Wright <[email protected]>

• References:
  • [PATCH] prevent NULL mmap in topdown model
    • From: Rik van Riel <[email protected]>
  • Re: [PATCH] prevent NULL mmap in topdown model
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] prevent NULL mmap in topdown model
    • From: Rik van Riel <[email protected]>

• Prev by Date: Re: [RFC] [PATCH] OCFS2
• Next by Date: why nfs server delay 10ms in nfsd_write()?
• Previous by thread: Re: [PATCH] prevent NULL mmap in topdown model
• Next by thread: Re: [PATCH] prevent NULL mmap in topdown model
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]