Arnd Bergmann wrote:
> On Dinsdag 17 Mai 2005 22:40, Nathan Lynch wrote:
> > Arnd Bergmann wrote:
> > > +static volatile int wdrtas_miscdev_open = 0;
> > ...
> > > +static int
> > > +wdrtas_open(struct inode *inode, struct file *file)
> > > +{
> > > + /* only open once */
> > > + if (xchg(&wdrtas_miscdev_open,1))
> > > + return -EBUSY;
> >
> > The volatile and xchg strike me as an obscure method for ensuring only
> > one process at a time can open this file. Any reason a semaphore
> > couldn't be used?
>
> A semaphore would also be the wrong approach since we don't want
> processes to block but instead to fail opening the watchdog twice.
I should have been more explicit. What I had in mind was using
down_trylock and returning -EBUSY if it failed.
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
