Re: [PATCH 2.6.12-rc4-mm2] perfctr: x86 update with K8 multicore fixes, take 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mikael Pettersson <[email protected]> writes:

> +#ifdef CONFIG_SMP
> +static void __init k8_multicore_init(void)
> +{
> +	cpumask_t non0cores;
> +	int i;
> +
> +	cpus_clear(non0cores);
> +	for(i = 0; i < NR_CPUS; ++i) {
> +		cpumask_t cores = cpu_core_map[i];
> +		int core0 = first_cpu(cores);
> +		if (core0 >= NR_CPUS)
> +			continue;
> +		cpu_clear(core0, cores);
> +		cpus_or(non0cores, non0cores, cores);
> +	}
> +	if (cpus_empty(non0cores))
> +		return;
> +	k8_is_multicore = 1;

That is still far too complicated. Just use current_cpu_data->x86_num_cores > 1 
That is simple enough that you don't need the ugly variable.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux