On Tue, May 17, 2005 at 04:25:37PM +1000, Nick Piggin wrote:
> >+
> >+ lock_cpu_hotplug();
> >+ partition_sched_domains(&pspan, &cspan);
> >+ unlock_cpu_hotplug();
> >+}
> >+
>
> I don't think the cpu hotplug lock isn't supposed to provide
> synchronisation between readers (for example, it may be turned
> into an rwsem), but only between the thread and the cpu hotplug
> callbacks.
That should be ok
>
> In that case, can you move this locking into kernel/sched.c, and
> add the comment in partition_sched_domains that the callers must
> take care of synchronisation (which without reading the code, I
> assume you're doing with the cpuset sem?).
I didnt want to do this as my next patch, which introduces
hotplug support for dynamic sched domains, also calls
partition_sched_domains. That code is called with the hotplug lock
already held. (I am still testing that code, it should be out by
this weekend)
However I will add a comment about the synchronization and yes
currently it is taken care of by the cpuset sem
-Dinakar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
