Re: [PATCH 4/8] ppc64: add BPA platform type

Arnd Bergmann writes:

> This adds the basic support for running on BPA machines.
> So far, this is only the IBM workstation, and it will
> not run on others without a little more generalization.

> +/* FIXME: consolidate this into rtas.c or similar */
> +static void __init pSeries_calibrate_decr(void)

Shouldn't this be called bpa_calibrate_decr or something similar?

> -#define	PV_630        	0x0040
> -#define	PV_630p	        0x0041
> +#define	PV_630		0x0040
> +#define	PV_630p		0x0041

Hmmm, I don't think your patch needs to clean up the whitespace here.

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/8] ppc64: add BPA platform type
    • From: Arnd Bergmann <[email protected]>

• References:
  • [PATCH 0/8] ppc64: Introduce Cell/BPA platform, v2
    • From: Arnd Bergmann <[email protected]>
  • [PATCH 4/8] ppc64: add BPA platform type
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: Re: [PATCH] Fix root hole in raw device
• Next by Date: Re: What breaks aic7xxx in post 2.6.12-rc2 ?
• Previous by thread: [PATCH 4/8] ppc64: add BPA platform type
• Next by thread: Re: [PATCH 4/8] ppc64: add BPA platform type
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]