Re: [PATCH] namespace.c: fix bind mount from foreign namespace

Miklos Szeredi wrote:
> +		if (ns1 < ns2) {
> +			down_write(&ns1->sem);
> +			down_write(&ns2->sem);
> +		} else {
> +			down_write(&ns2->sem);
> +			down_write(&ns1->sem);
> +		}

That's a bit smaller (source and compiled) as:

	if (ns2 < ns1)
		down_write(&ns2->sem);
	down_write(&ns1->sem);
	if (ns2 > ns1)
		down_write(&ns2->sem);

(And you'll notice that does the right thing if ns2==ns1 too, in case
that gives you any ideas.)

Otherwise, the patch looks convincing to me.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Miklos Szeredi <[email protected]>

• References:
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Ram <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Miklos Szeredi <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Miklos Szeredi <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Ram <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Jamie Lokier <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Ram <[email protected]>
  • Re: [PATCH] namespace.c: fix bind mount from foreign namespace
    • From: Miklos Szeredi <[email protected]>

• Prev by Date: Re: serial console
• Next by Date: Re: [PATCH] namespace.c: fix mnt_namespace clearing
• Previous by thread: Re: [PATCH] namespace.c: fix bind mount from foreign namespace
• Next by thread: Re: [PATCH] namespace.c: fix bind mount from foreign namespace
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]