On Mon, 2005-05-16 at 09:18 -0500, James Bottomley wrote:
> On Mon, 2005-05-16 at 10:06 +0200, Arjan van de Ven wrote:
> > > + spin_lock( instance->host_lock );
> > > + cmd->scmd->scsi_done( cmd->scmd );
> > > + spin_unlock( instance->host_lock );
> >
> > are you really sure you don't want to use spin_lock_irqsave() here ?
>
> Actually, don't bother with the lock at all. scsi_done() is designed to
> be called locklessly.
doh sorry I missed that (but knew it)
proves I need to drink the coffee BEFORE the patch review ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
