Re: [PATCH 2.6.12-rc4 1/12] (dynamic sysfs callbacks) update device attribute callbacks

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Sat, May 14, 2005 at 05:23:56AM -0400, Yani Ioannou wrote:
> This patch updates all device attribute callbacks to match the
> previously submitted sysfs dynamic callback device attribute patch
> which added the void * to the callback function signatures.

I missed commenting on this first time round.  What is the purpose behind
this idea?

Currently, sysfs attributes are generally static structures which don't
require allocation, and are shared between all objects.  I'm unable to
see what advantage adding this void pointer is supposed to give us,
other than having to dynamically allocate these structures if we want
to use them.

What's more, I don't really see what adding this buys us - we already
have the pointer which is supposed to identify the object passed in.

There's another question - how is the lifetime of the object pointed
to by this void pointer managed?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/