Re: [RFC][PATCH] timers fixes/improvements

Btw, i think that drivers/net/e1000/e1000_main.c:e1000_down() is buggy.

It calls del_timer_sync(&adapter->watchdog_timer), but e1000_watchdog()
calls schedule_work(e1000_watchdog_task), so the work could be queued
after del_timer_sync().

And e1000_watchdog_task() arms timers again.

Note that it's not enough to do flush_scheduled_work() here.

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH] timers fixes/improvements
    • From: Ganesh Venkatesan <[email protected]>

• References:
  • Re: [RFC][PATCH] timers fixes/improvements
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC][PATCH] timers fixes/improvements
    • From: Oleg Nesterov <[email protected]>
  • Re: [RFC][PATCH] timers fixes/improvements
    • From: Christoph Lameter <[email protected]>

• Prev by Date: [RFC/PATCH 2/5] mm/fs: add execute in place support
• Next by Date: Re: RCU + SMR for preemptive kernel/user threads.
• Previous by thread: Re: [RFC][PATCH] timers fixes/improvements
• Next by thread: Re: [RFC][PATCH] timers fixes/improvements
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]