On Tue, 10 May 2005, Andrew Morton wrote:
> Jesper Juhl <[email protected]> wrote:
> >
> > - if (b == NULL || already_uses(a, b)) return 1;
> > + if (b == NULL || already_uses(a, b))
> > + return 1;
>
> There are about 88 squillion of these in the kernel. I think it would be a
> mistake for me to start taking such patches, sorry.
>
Yes, there are a ton of these. There are also a ton of files that use
spaces instead of tabs, and a ton of files that use spaces between
function name and opening parenthesis - like foo (arg); or even
foo ( arg ) ;
Just because there are lost of them doesn't (in my oppinion) mean that
they shouldn't be cleaned up. Reading code that doesn't adhere to
CodingStyle is annoying at best, and hides bugs at worst.
There's no way I'm going to clean it all up - especially not if you don't
want the patches, but I think it *ought* to be cleaned up, and if you
should change your mind then I'm willing to clean up at least a fair bit
of it.
--
Jesper
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
