Re: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL

On Wednesday 11 May 2005 00:06, Jesper Juhl wrote:
> It doesn't make sense to cast NULL. This patch removes the pointless casts 
> from drivers/atm/nicstar.c

> --- linux-2.6.12-rc3-mm3-orig/drivers/atm/nicstar.c
> +++ linux-2.6.12-rc3-mm3/drivers/atm/nicstar.c

>     scq = (scq_info *) kmalloc(sizeof(scq_info), GFP_KERNEL);
            ^^^^^^^^^^^^
> -   if (scq == (scq_info *) NULL)
> -      return (scq_info *) NULL;
> +   if (scq == NULL)
> +      return NULL;

>     scq->skb = (struct sk_buff **) kmalloc(sizeof(struct sk_buff *) *
                 ^^^^^^^^^^^^^^^^^^^
>                                            (size / NS_SCQE_SIZE), GFP_KERNEL);
> -   if (scq->skb == (struct sk_buff **) NULL)
> +   if (scq->skb == NULL)

These are pointless too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
    • From: Jesper Juhl <[email protected]>

• References:
  • [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
    • From: Jesper Juhl <[email protected]>

• Prev by Date: Re: [RFC] RCU and CONFIG_PREEMPT_RT progress
• Next by Date: Re: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
• Previous by thread: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
• Next by thread: Re: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]