Re: [PATCH] sync_sb_inodes cleanup

[Robert Love <rml@novell.com>]

On Tue, 2005-05-10 at 19:00 +0400, Vladimir Saveliev wrote:

> This patch makes generic_sync_sb_inodes to spin lock itself.
> Please, apply this patch. It helps reiser4 to get rid of some oddities.
>
> [snip]
>
>  {
>         const unsigned long start = jiffies;    /* livelock avoidance */
>  
> +       spin_lock(&inode_lock);

Looking at what jiffies is used for, it is probably is not a big deal,
but you should move the assignment of start to after acquiring the lock,
as that could take quite some time.

	Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/