On Saturday 07 May 2005 08:10, Hyok S. Choi wrote:
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/Makefile
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/Makefile
> +#
> +# Makefile for the linux kernel.
> +#
> +# Object file lists.
Useless comments.
> +obj-y += arch.o irq.o time.o
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/arch.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/arch.c
[21 #include directives snipped]
> +extern void atmel_time_init(void);
> +extern unsigned long atmel_gettimeoffset(void);
> +
> +extern void __init atmel_init_irq(void);
> +
> +extern struct sys_timer atmel_timer;
> +
> +MACHINE_START(ATMEL, "ATMEL EB01")
> + MAINTAINER("Hyok S. Choi <[email protected]>")
> + INITIRQ(atmel_init_irq)
> + .timer = &atmel_timer,
> +MACHINE_END
So, all you need is:
include/linux/init.h
include/asm-arm/mach/time.h
include/asm-arm/mach/arch.h
And maybe one or two more.
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/irq.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/irq.c
> +static unsigned char eb01_irq_prtable[32] = {
Should it be ...[NR_IRQS] ?
> + 7 << 5, /* FIQ */
> + 0 << 5, /* SWIRQ */
> + 0 << 5, /* US0IRQ */
> + 0 << 5, /* US1IRQ */
> + 2 << 5, /* TC0IRQ */
> + 2 << 5, /* TC1IRQ */
> + 2 << 5, /* TC2IRQ */
> + 0 << 5, /* WDIRQ */
> + 0 << 5, /* PIOAIRQ */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 1 << 5, /* IRQ0 */
> + 0 << 5, /* IRQ1 */
> + 0 << 5, /* IRQ2 */
> +};
You are doing "eb01_irq_prtable[irq] >> 5" always.
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel(irq, AIC_EOICR);
> + }
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel((eb01_irq_prtable[irq] >> 5) | eb01_irq_type[irq],
> + AIC_SMR(irq));
> + }
Use consistent style for "for" statements and brackets. Like in the next line.
> + for (irq = 0; irq < NR_IRQS; irq++) {
Please, remove trailing whitespace from this patch. There is quite a few of
it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]