Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)

On Fri, 6 May 2005, Andrew Morton wrote:

> 
> This patch adds behavioural changes:
> 
> -		if (j->read_buffer) {
> -			kfree(j->read_buffer);
> -			j->read_buffer = NULL;
> -			j->read_buffer_size = 0;
> -		}
> +		j->read_buffer = NULL;
> +		j->read_buffer_size = 0;
> 
> Now we'll zero ->read_buffer_size even if ->read_buffer was already NULL.
> 
> It's hard to believe that this could cause any problems, but please check
> that.
> 
When I initially read the code I didn't see any harm that could be done by 
that, but I'll take a second more careful look and report back - I'm 
pretty sure it's safe though.
I'll do this tomorrow since I'm off to catch some sleep now.

-- 
Jesper

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
    • From: Jesper Juhl <[email protected]>

• References:
  • [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
• Next by Date: Re: [PATCH] ppc64: kexec support for ppc64
• Previous by thread: Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
• Next by thread: Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]