[PATCH 1/2] video/tuner: fix tuner->freq updating

[Jiri Benc <jbenc@suse.cz>]

In VIDIOC_S_FREQUENCY command in tuner-core.c, t->freq is set to a new
value before calling set_freq(). This is not necessary, as set_freq()
sets t->freq itself. Moreover, it causes problems with Philips tuners,
as they need to take into consideration difference between previous and
new frequency.


Signed-off-by: Jiri Benc <jbenc@suse.cz>

--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -357,8 +357,7 @@
 		    V4L2_TUNER_RADIO != t->mode)
 			set_tv_freq(client,400*16);
 		t->mode  = f->type;
-		t->freq  = f->frequency;
-		set_freq(client,t->freq);
+		set_freq(client,f->frequency);
 		break;
 	}
 	case VIDIOC_G_TUNER:



--
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/