Re: [3/3] sparsemem memory model for ppc64

[Olof Johansson <olof@lixom.net>]

Hi,

Just two formatting nitpicks below.

-Olof

On Wed, May 04, 2005 at 09:30:57PM +0100, Andy Whitcroft wrote:
> diff -X /home/apw/brief/lib/vdiff.excl -rupN reference/arch/ppc64/mm/init.c current/arch/ppc64/mm/init.c
> --- reference/arch/ppc64/mm/init.c	2005-05-04 20:54:20.000000000 +0100
> +++ current/arch/ppc64/mm/init.c	2005-05-04 20:54:54.000000000 +0100
[...]
> @@ -623,12 +631,18 @@ void __init do_init_bootmem(void)
>  
>  	max_pfn = max_low_pfn;
>  
> -	/* add all physical memory to the bootmem map. Also find the first */
> +	/* add all physical memory to the bootmem map. Also, find the first
> +	 * presence of all LMBs*/

CodingStyle:   */  on new line

>  	for (i=0; i < lmb.memory.cnt; i++) {
>  		unsigned long physbase, size;
>  
>  		physbase = lmb.memory.region[i].physbase;
>  		size = lmb.memory.region[i].size;
> +		if (i) { /* already created mappings for first LMB */
> +			start_pfn = physbase >> PAGE_SHIFT;
> +			end_pfn = start_pfn + (size >> PAGE_SHIFT);

Comment on new line indented, please


-Olof
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/