Andi Kleen <[email protected]> wrote:
>
> On Mon, May 02, 2005 at 11:31:25AM -0700, Andrew Morton wrote:
> > Andi Kleen <[email protected]> wrote:
> > >
> > > >
> > > > Doing it either way should be OK with this mce code. But I feel,
> > > > despite of the patch size, it is better to keep all the shared
> > > > code in i386 tree and link it from x86-64. Otherwise, it may become
> > > > kind of messy in future, with various links between i386 and x86-64.
> > >
> > > i386 already uses code from x86-64 (earlyprintk.c) - it is nothing
> > > new.
> >
> > I must say I don't like the bidirectional sharing either.
>
> Why exactly?
One reason is that it makes it harder to locate the code. I ctag each of
my architecture trees only with stuff from ./arch/that-architecture to reduce
duplicate hits. So I end up with some x86 functions being unlocatable in
the x86 tree. We end up with both x86_64 and x86 being broken in this
regard.
But that's a relatively minor point. The major point is that it gives me
the creeps in hard-to-define ways ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]