On Thu, 2005-04-28 at 12:12 -0400, Lee Revell wrote: > On Thu, 2005-04-28 at 00:37 -0700, Mingming Cao wrote: > > On Wed, 2005-04-27 at 23:45 -0400, Lee Revell wrote: > > > On Fri, 2005-04-22 at 15:10 -0700, Mingming Cao wrote: > > > > Please review. I have tested on fsx on SMP box. Lee, if you got time, > > > > please try this patch. > > > > > > I have tested and this does fix the problem. I ran my tests and no ext3 > > > code paths showed up on the latency tracer at all, it never went above > > > 33 usecs. > > > > > Thanks, Lee. > > > > The patch survived on many fsx test over 20 hours on a 2cpu machine. > > Tested the patch on the same machine with tiobench (1-64 threads), and > > untar a kernel tree test, no regression there. > > However I see about 5-7% throughput drop on dbench with 16 threads. It > > probably due to the cpu cost that we have discussed. > > Hmm, I guess someone needs to test it on a bigger system. AFAICT this > should improve SMP scalability quite a bit. Maybe that lock is rarely > contended. Probably. I will try it on a relatively full filesystem(where bitmap scan to find a free block takes time), and on a 4 cpu box with many threads allocating at the same time. Mingming - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Mingming Cao <[email protected]>
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- References:
- ext3 allocate-with-reservation latencies
- From: Lee Revell <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Ingo Molnar <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Ingo Molnar <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Mingming Cao <[email protected]>
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Lee Revell <[email protected]>
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Mingming Cao <[email protected]>
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Lee Revell <[email protected]>
- ext3 allocate-with-reservation latencies
- Prev by Date: Re: Extremely poor umass transfer rates
- Next by Date: RE: x86-64 dual core mapping
- Previous by thread: Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- Next by thread: Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- Index(es):