Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL

Badari Pulavarty <[email protected]> writes:

> Andrew confirmed that this is a valid case.
>
> I don't understand what you want to do here ? If the mapping is NULL,
> we can't de-ref it.  Whats the point in putting a warning and de-refing
> it. Its going to cause NULL pointer de-ref anyway.

I meant your patch + warning. If it is just bh leak, not valid state,
I thought we can notice the leak of bh by warning.

I wanted above things. If it's valid state, of course warning is just
crap.

Sorry for noise.
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL
  - From: Badari Pulavarty <[email protected]>
- Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL
  - From: OGAWA Hirofumi <[email protected]>
- Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL
  - From: Badari Pulavarty <[email protected]>

Prev by Date: Re: [PATCH 0/7] dlm: overview
Next by Date: Re: DRI lockup on R200, 2.6.11.7
Previous by thread: Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL
Next by thread: oops data from direct memory dump of log_buf?
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]