Re: [PATCH: 1 of 12] Fix concerns with TPM driver -- use enums

On Wed, Apr 27, 2005 at 05:15:46PM -0500, Kylene Hall wrote:
>  /* Atmel definitions */
> -#define	TPM_ATML_BASE			0x400
> +enum {
> +	TPM_ATML_BASE = 0x400
> +};

Please name your enumerated types, so that you can try to check for
type-safeness on them.  Just converting them to a enum doesn't do really
anything...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH: 1 of 12] Fix concerns with TPM driver -- use enums
  - From: Kylene Hall <[email protected]>

Prev by Date: [PATCH 10 of 12] Fix Tpm driver -- sysfs owernship changes
Next by Date: Re: any way to find out kernel memory usage?
Previous by thread: [PATCH: 1 of 12] Fix concerns with TPM driver -- use enums
Next by thread: [PATCH: 1 of 12] Fix concerns with TPM driver -- use enums
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]