Re: [PATCH] 2.4.30 PicoPower IRQ router

[Jesper Juhl <juhl-lkml@dif.dk>]

A few more style comments below. Nice cleanup compared to the first 
version though. Now let's get it perfect :-)

On Wed, 27 Apr 2005, Sune Mølgaard wrote:

> Domen Puncer wrote:
> > On 26/04/05 21:00 +0200, Sune Mølgaard wrote:
> > 
> > Signed-off-by? And weird indentification, try to use tabs.
> > 
> 
> Signed-off-by Sune Molgaard sune@molgaard.org

Proper form would be:  Signed-off-by: Sune Molgaard <sune@molgaard.org>


> +static int pirq_pico_set(struct pci_dev *router, struct pci_dev *dev, int
> pirq, int irq)
> +{
> +        outb(0x10+((pirq-1)>>1), 0x24);
   ^^^^^^^^
   Proper indentation depth (8 chars)

> +       unsigned int x;
   ^^^^^^^
   Only 7 char indentation.

This mismatch is found several places in the patch. Besides, the patch 
seems whitespace damaged - the lines seem to be indented with spaces, not 
tabs. Perhaps your email client mangled it?

(note: Chapter 1 of Documentation/CodingStyle describes proper 
 indentation)


> +        switch(device)
> +       {

The opening brace goes on the same line as the switch statement.

See Documentation/CodingStyle Chapter 2


-- 
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/