Using __user with compat_uptr_t

Hi Linus,

I've added a couple of structures for dealing with 32-bit -> 64-bit upgrade of
NFS4 mounts. They represent the NFS4 mount information provided by userspace
and they contain some pointers to further userspace data. Should these further
userspace pointers be labelled __user?

For example, is this right?:

	struct compat_nfs_string {
		compat_uint_t len;
		compat_uptr_t __user data;
	};

Or is this right?:

	struct compat_nfs_string {
		compat_uint_t len;
		compat_uptr_t data;
	};

Now it makes no difference to the compiler, but it might affect the checker
tool.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] NFS4: Don't use __user with compat_uptr_t
    • From: David Howells <[email protected]>
  • Re: Using __user with compat_uptr_t
    • From: Linus Torvalds <[email protected]>

• References:
  • Re: [PATCH] Add 32-bit compatibility for NFSv4 mount
    • From: Stephen Rothwell <[email protected]>
  • [PATCH] Add 32-bit compatibility for NFSv4 mount
    • From: David Howells <[email protected]>

• Prev by Date: Re: [PATCH] private mounts
• Next by Date: [PATCH] fix via82xx resume
• Previous by thread: Re: [PATCH] Add 32-bit compatibility for NFSv4 mount
• Next by thread: Re: Using __user with compat_uptr_t
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]