On Mon, Apr 25, 2005 at 05:53:49PM +0200, Jesper Juhl wrote:
> On Mon, 25 Apr 2005, David Teigland wrote:
> > +static ssize_t dlm_id_store(struct dlm_ls *ls, const char *buf, size_t len)
> > +{
> > + ls->ls_global_id = simple_strtol(buf, NULL, 0);
> > + return len;
> > +}
>
> What's the point of `len' in these two functions?
> You pass in `len`, don't use it at all, then return the value. I fail to
> see the usefulness. Why not just have the function return void and omit
> the `len' parameter?
Do I have a choice? Aren't these stipulated by sysfs?
static ssize_t dlm_attr_store(struct kobject *kobj, struct attribute *attr,
const char *buf, size_t len)
{
struct dlm_ls *ls = container_of(kobj, struct dlm_ls, ls_kobj);
struct dlm_attr *a = container_of(attr, struct dlm_attr, attr);
return a->store ? a->store(ls, buf, len) : len;
}
static struct sysfs_ops dlm_attr_ops = {
.show = dlm_attr_show,
.store = dlm_attr_store,
};
Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
