Re: [RFC][PATCH] nameing reserved pages [1/3]

Hi!
Pavel Machek wrote:

         ~
	  missing e?

Oh, it's typo :(. thanks!

+	Reserved_At_Boot,
+	Max_Reserved_Types,
+	Page_Invalid = 0xff
+};

You certainly use unusual naming convention here. Could we get
reserved_at_boot instead? (I.e. all lowercase).

Okay.

+static inline void set_page_reserved(struct page *page, unsigned char type)
+{

Make it enum page_type type.

I'll do.

Thanks
-- Kame <[email protected]>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH] nameing reserved pages [1/3]
    • From: KAMEZAWA Hiroyuki <[email protected]>
  • Re: [RFC][PATCH] nameing reserved pages [1/3]
    • From: Pavel Machek <[email protected]>

• Prev by Date: Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's
• Next by Date: Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()
• Previous by thread: Re: [RFC][PATCH] nameing reserved pages [1/3]
• Next by thread: [RFC][PATCH] nameing reserved pages [2/3]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]