Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

On Fri, Apr 15, 2005 at 02:31:00AM +0100, Matthew Wilcox wrote:
> On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote:
> > 'arg' is unsigned so it can never be less than zero, so testing for that 
> > is pointless and also generates a warning when building with gcc -W. This 
> > patch eliminates the pointless check.
> 
> Didn't Linus already reject this one 6 months ago?

I think Linux only complained if we're using some typedef that actually
may be signed.  For fcntl that 'arg' argument is unsigned and that's hardcoded
in the ABI.  So the check doesn't make sense at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
    • From: Matthew Wilcox <[email protected]>

• References:
  • [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: Re: ALSA Oops (triggered by xmms)
• Next by Date: Re: [patch 1/1] nbd: Don't create all MAX_NBD devices by default all the time
• Previous by thread: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
• Next by thread: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]