Re: [PATCH] sched: fix never executed code due to expression always false

On Fri, 2005-04-15 at 12:59 +1000, Herbert Xu wrote:
> Jesper Juhl <[email protected]> wrote:
> >
> > -               if (unlikely((long long)now - prev->timestamp < 0))
> > +               if (unlikely(((long long)now - (long long)prev->timestamp) < 0))
> 
> You can write this as
> 
> (long long)(now - prev->timestamp)
> 

True. Combined that with Matt's suggestion, and we probably have
the cleanest solution. Thanks.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] sched: fix never executed code due to expression always false
    • From: Herbert Xu <[email protected]>

• Prev by Date: Re: Linux support for IBM ThinkPad Disk shock prevention update...
• Next by Date: [PATCH] Platform SMIs and their interferance with tsc based delay calibration
• Previous by thread: Re: [PATCH] sched: fix never executed code due to expression always false
• Next by thread: Re: [PATCH] sched: fix never executed code due to expression always false
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]