Re: [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use

On Wed, Apr 13, 2005 at 04:17:34AM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
 
Again, check is a pure BS.  Argument passed to this sucker comes from
->Instance of the same struct that had ->Handler equal to mace_interrupt().
That would be
    link->irq.Handler = &mace_interrupt;
    link->irq.Instance = dev;
in nmclan_attach().  Nothing ever modifies that beast afterwards and dev
sure as hell can't be NULL in nmclan_attach() (explict check and a bunch
of dereferencings prior to that point).

Adrian, could you please _read_ the code you are modifying?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [2.6 patch] fs/udf/inode.c: fix a check after use
• Next by Date: Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
• Previous by thread: [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use
• Next by thread: [2.6 patch] drivers/scsi/sg.c: fix check after use
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]