Re: [2.6 patch] sound/oss/cs46xx.c: fix a check after use

On Wed, Apr 13, 2005 at 04:17:39AM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.

NAK.  Please, read the surrounding code.  All places that can call
that function have form
	<expression>->amplifier_ctrl(<same expression>,...);
so we _can't_ get NULL first argument.  The check should be removed -
it's not paranoia, it's simple stupidity.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] sound/oss/cs46xx.c: fix a check after use
    • From: Adrian Bunk <[email protected]>

• Prev by Date: [patch 083/198] x86_64: Fix a small missing schedule race
• Next by Date: [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use
• Previous by thread: [2.6 patch] sound/oss/cs46xx.c: fix a check after use
• Next by thread: [2.6 patch] drivers/pci/msi.c: fix a check after use
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]