Re: [patch 6/9] blk: unplug later

Andrew Morton wrote:

Nick Piggin <[email protected]> wrote:

get_request_wait needn't unplug the device immediately.

Probably.  But what if the get_request(q, rw, GFP_NOIO); did
some sleeping?

It can't sleep unless it returns the request, because it
is using mempool allocs. So any time it returns NULL, it
hasn't slept.

But Jens would have a better idea of the correct behaviour.
Jens, what do you think?

--
SUSE Labs, Novell Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 6/9] blk: unplug later
    • From: Jens Axboe <[email protected]>

• References:
  • [patch 0/9] various (mainly mempool fixes and block layer improvements)
    • From: Nick Piggin <[email protected]>
  • [patch 6/9] blk: unplug later
    • From: Nick Piggin <[email protected]>
  • Re: [patch 6/9] blk: unplug later
    • From: Andrew Morton <[email protected]>

• Prev by Date: [patch 3/3]: fix BAD_SYSCALL_EXIT lockup
• Next by Date: Re: 2.6.12-rc2-mm2
• Previous by thread: Re: [patch 6/9] blk: unplug later
• Next by thread: Re: [patch 6/9] blk: unplug later
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]