Re: [PATCH] ppc32: refactor FPU exception handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ben,

Sorry about that, we have had some back and forth on this on the ppc embedded list.

Not sure I understand your concern about the duplication of the fast exception return path? Jason's patch pretty much just moved code out of head.S into fpu.S so we dont duplicate it between head.S and head_44x.S & head_fsl_booke.S

- kumar

On Apr 11, 2005, at 9:28 PM, Benjamin Herrenschmidt wrote:

On Mon, 2005-04-11 at 17:02 -0500, Kumar Gala wrote:
 > Andrew,
 >
> Moved common FPU exception handling code out of head.S so it can be used > by several of the sub-architectures that might of a full PowerPC FPU. 
>
> Also, uses new CONFIG_PPC_FPU define to fix alignment exception
> handling for floating point load/store instructions to only occur if we
> have a hardware FPU.
>
> Signed-off-by: Jason McMullan <[email protected]>
> Signed-off-by: Kumar Gala <[email protected]>



Andrew, please hold on this patch, it hasn't been properly discussed
 with the relevant maintainer, that is Paul Mackerras.

I can see matter for debate in there, like the whole duplication of the
 fast exception return path...

It's also touching quite sensitive bits of kernel code (head.S) that
 needs careful auditing and testing before beeing pushed upstream.

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux