Re: [PATCH 2.6.11.7 1/1] x86 reboot: Add reboot fixup for gx1/cs5530a

["Richard B. Johnson" <linux-os@analogic.com>]

On Mon, 11 Apr 2005, H. Peter Anvin wrote:

> jayalk@intworks.biz wrote:
> > Hi Riley, Dave, Peter, i386 boot/workaround maintainers,
> >
> > I'm resending this patch (from March 28).
> >
> > This patch incorporates the suggestions from the previous thread and also
> > switches to using pci_get_device since pci_find_device is deprecated, and
> > made some of the variables static.
> >
> > Please let me know if it's okay.
>
> > +#define mach_reboot_fixups(x) do {} while (0)
>
> As I stated last time, this should be:
>
> #define mach_reboot_fixup(x)	((void)(x))
>
> ... to preserve side effects, and be expression-like.
>
> 	-hpa

Shouldn't it just be:

#define mach_reboot_fixup(x)
                              |___ Nothing here.

Cheers,
Dick Johnson
Penguin : Linux version 2.6.11 on an i686 machine (5537.79 BogoMips).
 Notice : All mail here is now cached for review by Dictator Bush.
                 98.36% of all statistics are fiction.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/