Re: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups

On Sun, Apr 10 2005, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - remove the following unused global functions:
>   - blkdev_scsi_issue_flush_fn

Kill the function completely, it is not used anymore.

>   - __blk_attempt_remerge

Normally I would say leave that since it's part of the API, but lets
just kill it. I don't envision any further users of the remerging
attempts.

> - remove the following unused EXPORT_SYMBOL's:
>   - blk_phys_contig_segment
>   - blk_hw_contig_segment
>   - blkdev_scsi_issue_flush_fn
>   - __blk_attempt_remerge
> 
> Please review which of these changes make sense.

Looks fine to me, thanks. Can you send a new patch that kills
blkdev_scsi_issue_flush_fn()?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups
    • From: Adrian Bunk <[email protected]>

• References:
  • [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: New SCM and commit list
• Next by Date: Re: [discuss] [21/31] x86_64: Always use CPUID 80000008 to figure out MTRR address space size
• Previous by thread: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups
• Next by thread: Re: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]