Re: [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG()

Hi Andrew, all,

> In a case documented as
> 
>   We should never be called with any of these states
> 
> BUG() in a case that would later result in a NULL pointer dereference.
> 
> Signed-off-by: Adrian Bunk <[email protected]>
> 
> --- linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c.old	2005-03-26 13:19:19.000000000 +0100
> +++ linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c	2005-03-26 13:41:30.000000000 +0100
> @@ -786,8 +642,7 @@ int smb_request_recv(struct smb_sb_info 
>  		/* We should never be called with any of these states */
>  	case SMB_RECV_END:
>  	case SMB_RECV_REQUEST:
> -		server->rstate = SMB_RECV_END;
> -		break;
> +		BUG();
>  	}
>  
>  	if (result < 0) {

Can you please pick this one for next -mm?

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] fs/smbfs/request.c: fix NULL dereference
    • From: Adrian Bunk <[email protected]>
  • Re: [2.6 patch] fs/smbfs/request.c: fix NULL dereference
    • From: Jean Delvare <[email protected]>
  • [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG()
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: Kernel SCM saga..
• Next by Date: Re: [bk tree] DRM add a version check.. for 2.6.12 (distro kernel maintainers + drm users plz read also...)
• Previous by thread: Re: [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG()
• Next by thread: Error building ndiswrapper-1.0rc1 against 2.6.12-rc1-mm2 sources
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]