Re: [linux-usb-devel] USB glitches after suspend on ppc

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

> Interesting.  Looks like pci_enable_wake(dev, state, 0) isn't actually
> disabling wakeup on your hardware.  (Assuming CONFIG_USB_SUSPEND=n; if
> not, then it's odd that the system went back to sleep!)  Do you think
> that might be related to those calls manipulating the Apple ASICs being
> in the OHCI layer rather than up nearer the generic PCI glue?  (I still
> think they don't belong in USB code -- ohci or usbcore -- at all.  If
> the platform-specific PCI hooks don't suffice, they need fixing.)

There are no platform hooks in the right place for now afaik. Anyway, I
think Colin's controller is an OHCI/EHCI NEC chip, so not an Apple ASIC,
it's not doing anything in those calls.

> Thanks for the testing update.  I'm glad to know that there seems to
> be only one (minor) glitch that's PPC-specific!

Which is just an off-the-shelves NEC EHCI chip.

> > - once out of two resumes, resume leaves the ports unpowered; so I still
> > need my usb-ehci-power.patch that re-powers ports unconditionnaly.
> 
> OK, I just posted the patch cleaning up EHCI port power switching;
> that should remove the need for that separate patch.  (As well as
> fixing some minor annoyances.)
> 
> - Dave
> 
> 
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/