Greg KH wrote: > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, [email protected] > > [PATCH] PCI Hotplug: remove code duplication in > drivers/pci/hotplug/ibmphp_pci.c > > This patch removes some code duplication where if and else have the > same code at the beginning and the end of the branch. Greg, as you correctly pointed out this patch if broken. It could never reach the if branch and always uses the else branch. Please drop this one and review the patch I sent on March 21th to pcihp-discuss for inclusion. It removes much more duplication and handles this case correctly. Sorry, it looks like I forgot to CC you. I'll bounce this mail to you. Eike
Attachment:
pgphOANE0IVAQ.pgp
Description: PGP signature
- Follow-Ups:
- References:
- Prev by Date: Re: new SGI TIOCX driver in *-mm driver model locking broken
- Next by Date: Re: new SGI TIOCX driver in *-mm driver model locking broken
- Previous by thread: [PATCH] PCI: create PCI_DEBUG config option to make it easier for users to enable pci debugging
- Next by thread: Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c
- Index(es):
 |