[PATCH] drivers/pci/msi.c: fix a check after use

ChangeSet 1.2181.16.24, 2005/03/28 15:20:34-08:00, [email protected]

[PATCH] drivers/pci/msi.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>


 drivers/pci/msi.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)


diff -Nru a/drivers/pci/msi.c b/drivers/pci/msi.c
--- a/drivers/pci/msi.c	2005-04-01 15:31:25 -08:00
+++ b/drivers/pci/msi.c	2005-04-01 15:31:25 -08:00
@@ -703,11 +703,13 @@
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-	int pos, temp = dev->irq, status = -EINVAL;
+	int pos, temp, status = -EINVAL;
 	u16 control;
 
 	if (!pci_msi_enable || !dev)
  		return status;
+
+	temp = dev->irq;
 
 	if ((status = msi_init()) < 0)
 		return status;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • PCI: clean up the dynamic id logic a little bit.
    • From: Greg KH <[email protected]>

• References:
  • [PATCH] PCI: remove pci_find_device usage from pci sysfs code.
    • From: Greg KH <[email protected]>

• Prev by Date: PCI Hotplug: enforce the rule that a hotplug slot needs a release function.
• Next by Date: [PATCH] PCI busses are structs, not integers
• Previous by thread: [PATCH] PCI: remove pci_find_device usage from pci sysfs code.
• Next by thread: PCI: clean up the dynamic id logic a little bit.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]