Re: [RFC] Add support for semaphore-like structure with support for asynchronous I/O

[Andrew Morton <akpm@osdl.org>]

Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> In NFSv4 we often want to serialize asynchronous RPC calls with ordinary
> RPC calls (OPEN and CLOSE for instance). On paper, semaphores would
> appear to fit the bill, however there is no support for asynchronous I/O
> with semaphores.
> <rant>What's more, trying to add that type of support is an exercise in
> futility: there are currently 23 slightly different arch-dependent and
> over-optimized versions of semaphores (not counting the different
> versions of read/write semaphores).</rant>

Yeah.

> Anyhow, the following is a simple implementation of semaphores designed
> to satisfy the needs of those I/O subsystems that want to support
> asynchronous behaviour too. Please comment.
> 

So I've been staring at this code for a while and I Just Don't Get It.  If
I want some custom callback function to be called when someone does an
iosem_unlock(), how do I do it?

Or have I misunderstood the intent?  Some /* comments */ would be appropriate..

> +struct iosem {
> +	unsigned long state;
> +	wait_queue_head_t wait;
> +};
> +
> +#define IOSEM_LOCK_EXCLUSIVE (24)
> +/* #define IOSEM_LOCK_SHARED (25) */
> +
> +struct iosem_wait {
> +	struct iosem *lock;
> +	wait_queue_t wait;
> +};
> +
> +struct iosem_work {
> +	struct work_struct work;
> +	struct iosem_wait waiter;
> +};

Commenting the data structures is particularly helpful.

> +extern void FASTCALL(iosem_lock(struct iosem *lk));
> +extern void FASTCALL(iosem_unlock(struct iosem *lk));
> +extern int iosem_lock_wake_function(wait_queue_t *wait, unsigned mode, int sync, void *key);
> +
> +static inline void init_iosem(struct iosem *lk)
> +{
> +	lk->state = 0;
> +	init_waitqueue_head(&lk->wait);
> +}
> +
> +static inline void init_iosem_waiter(struct iosem_wait *waiter)
> +{
> +	waiter->lock = NULL;
> +	init_waitqueue_entry(&waiter->wait, current);
> +	INIT_LIST_HEAD(&waiter->wait.task_list);
> +}
> +
> +static inline void init_iosem_work(struct iosem_work *wk, void (*func)(void *), void *data)
> +{
> +	INIT_WORK(&wk->work, func, data);
> +}

I'd be inclined to call these iosem_init, iosem_waiter_init and
iosem_work_init.

> --- /dev/null
> +++ linux-2.6.12-rc1/lib/iosem.c
> @@ -0,0 +1,103 @@
> +/*
> + * linux/fs/nfs/iosem.c

This filename is stale.

> +	spin_lock(&lk->wait.lock);

I wonder if this lock should be irq-safe everywhere.  Is it not possible
that someone might want to do an unlock from irq context?

> +	if (lk->state != 0) {
> +		waiter->lock = lk;
> +		add_wait_queue_exclusive_locked(&lk->wait, &waiter->wait);
> +		ret = -EINPROGRESS;
> +	} else {
> +		lk->state |= 1 << IOSEM_LOCK_EXCLUSIVE;
> +		ret = 0;
> +	}
> +	spin_unlock(&lk->wait.lock);
> +	return ret;
> +}

Again, some commentary would be needed to help the poor reader understand
what a -EINPROGRESS return means.

> +	struct iosem_wait waiter;
> +
> +	might_sleep();
> +
> +	init_iosem_waiter(&waiter);
> +	waiter.wait.func = iosem_lock_wake_function;
> +
> +	set_current_state(TASK_UNINTERRUPTIBLE);
> +	if (__iosem_lock(lk, &waiter))
> +		schedule();
> +	__set_current_state(TASK_RUNNING);
> +
> +	BUG_ON(!list_empty(&waiter.wait.task_list));
> +}

Is this BUG_ON() safe?  No locks are held, so couldn't another object get
added by some other thread of control?

> +int iosem_lock_and_schedule_function(wait_queue_t *wait, unsigned mode, int sync, void *key)
> +{
> +	struct iosem_wait *waiter = container_of(wait, struct iosem_wait, wait);
> +	struct iosem_work *wk = container_of(waiter, struct iosem_work, waiter);
> +	unsigned long *lk_state = &waiter->lock->state;
> +	int ret = 0;
> +
> +	if (*lk_state == 0) {
> +		ret = schedule_work(&wk->work);
> +		if (ret) {
> +			*lk_state |= 1 << IOSEM_LOCK_EXCLUSIVE;
> +			list_del_init(&wait->task_list);
> +		}
> +	}
> +	return ret;
> +}

Again, I don't understand why this function was created.  I think it means
that there are restrictions upon what keventd can do with iosems, to avoid
deadlocking.  If correct, they should be spelled out.

> +int fastcall iosem_lock_and_schedule_work(struct iosem *lk, struct iosem_work *wk)
> +{
> +	int ret;
> +
> +	init_iosem_waiter(&wk->waiter);
> +	wk->waiter.wait.func = iosem_lock_and_schedule_function;
> +	ret = __iosem_lock(lk, &wk->waiter);
> +	if (ret == 0)
> +		ret = schedule_work(&wk->work);
> +	return ret;
> +}
> +EXPORT_SYMBOL(iosem_lock_and_schedule_work);

Ditto.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/