Re: [PATCH] Pageset Localization V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +#define MAKE_LIST(list, nlist)  \
> +	do {    \
> +		if(list_empty(&list))      \
> +			INIT_LIST_HEAD(nlist);          \
> +		else {  nlist->next->prev = nlist;      \
> +			nlist->prev->next = nlist;      \
> +		}                                       \
> +	}while(0)

This is horrible.  Where are the nlist pointers supposed to point to?
What's so magic you need the INIT_LIST_HEAD only conditionally?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux