Re: [patch] use cheaper elv_queue_empty when unplug a device

On Tue, 2005-03-29 at 19:19 +1000, Nick Piggin wrote:
> - removes the relock/retry merge mechanism in __make_request if we
>    aren't able to get the GFP_ATOMIC allocation. Just fall through
>    and assume the chances of getting a merge will be small (is this
>    a valid assumption? Should measure it I guess).

this may have a potential problem; if the vm gets in trouble, you
suddenly start to generate worse IO patterns, which means IO performance
goes down right when it's most needed.....

of course we need to figure if this actually ever hits in practice,
because if it doesn't I'm all for simpler code.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [patch] use cheaper elv_queue_empty when unplug a device
  - From: Nick Piggin <[email protected]>
- Re: [patch] use cheaper elv_queue_empty when unplug a device
  - From: Jens Axboe <[email protected]>

References:
- [patch] use cheaper elv_queue_empty when unplug a device
  - From: "Chen, Kenneth W" <[email protected]>
- Re: [patch] use cheaper elv_queue_empty when unplug a device
  - From: Jens Axboe <[email protected]>
- Re: [patch] use cheaper elv_queue_empty when unplug a device
  - From: Nick Piggin <[email protected]>

Prev by Date: Re: [PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set()
Next by Date: Re: [PATCH] API for true Random Number Generators to add entropy (2.6.11)
Previous by thread: Re: [patch] use cheaper elv_queue_empty when unplug a device
Next by thread: Re: [patch] use cheaper elv_queue_empty when unplug a device
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]