[PATCH] shrink drivers/pci/proc.c::pci_seq_start()

Hi,

this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead
of explicitely using a loop and avoiding a goto.

Eike

Signed-off-by: Rolf Eike Beer <[email protected]>

--- linux-2.6.11/drivers/pci/proc.c	2005-03-21 11:41:56.000000000 +0100
+++ linux-2.6.12-rc1/drivers/pci/proc.c	2005-03-27 16:03:10.000000000 +0200
@@ -313,13 +313,10 @@ static void *pci_seq_start(struct seq_fi
 	struct pci_dev *dev = NULL;
 	loff_t n = *pos;
 
-	dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
-	while (n--) {
-		dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
-		if (dev == NULL)
-			goto exit;
+	for_each_pci_dev(dev) {
+		if (!n--)
+			break;
 	}
-exit:
 	return dev;
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] shrink drivers/pci/proc.c::pci_seq_start()
    • From: Greg KH <[email protected]>

• Prev by Date: [PATCH] typo fix in Documentation/eisa.txt
• Next by Date: [PATCH] s/driverfs/sysfs/ in include/linux/cpu.h and net/sunrpc/rpc_pipe.c
• Previous by thread: [PATCH] typo fix in Documentation/eisa.txt
• Next by thread: Re: [PATCH] shrink drivers/pci/proc.c::pci_seq_start()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]