Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/

• To: [email protected]
• Subject: Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/
• From: Pekka Enberg <[email protected]>
• Date: Sun, 27 Mar 2005 17:00:01 +0300
• Cc: Jesper Juhl <[email protected]>, Neil Brown <[email protected]>, [email protected], Trond Myklebust <[email protected]>, [email protected], [email protected]
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=Z/FHdZXOKE3yRoTCJuoacrr+1rlm3R9+GDXHfVBrPyRnq0nG1XNRz7eh5fAbCBAEvKIYFnbdyNk9oPtfkbfWzU1G9SAK+QaLlwb3osIGGkc/uEkp07izbj6a31WWVMuZMOPxRygJp1hXblXVEW9XOtEADapq4mS86ZD5cAtDvbc=
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]>
• Reply-to: Pekka Enberg <[email protected]>
• Sender: [email protected]

On Fri, 25 Mar 2005 17:34:29 -0500 (EST), linux-os
<[email protected]> wrote:
> You really should reconsider this activity. It is quite counter-productive.

No it's not. NULL is checked twice without Jesper's cleanups. If
kfree() calls are really that performance sensitive, just make it
inline and GCC will take care of it.

                                        Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/
    • From: linux-os <[email protected]>

• Prev by Date: Re: Can't use SYSFS for "Proprietry" driver modules !!!.
• Next by Date: [PATCH rc1-mm3] timers: kill timer_list->lock
• Previous by thread: Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/
• Next by thread: [PATCH] don't check for NULL before calling kfree() in fs/ntfs/
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]