Hi Robert, it looks like you shouldn't call iput with spinlocks held. iput might call down into the filesystem to delete the inode and this can sleep. Mar 27 14:38:18 server Debug: sleeping function called from invalid context at include/asm/semaphore.h:102 Mar 27 14:38:18 server in_atomic():1, irqs_disabled():0 Mar 27 14:38:18 server [<c0103e37>] dump_stack+0x17/0x20 Mar 27 14:38:18 server [<c0118973>] __might_sleep+0xa3/0xb0 Mar 27 14:38:18 server [<c03fc5ab>] lock_kernel+0x2b/0x50 Mar 27 14:38:18 server [<c019fc33>] reiserfs_delete_inode+0x13/0x100 Mar 27 14:38:18 server [<c0172c64>] generic_delete_inode+0xa4/0x160 Mar 27 14:38:18 server [<c0172f16>] iput+0x56/0x80 Mar 27 14:38:18 server [<c017f9bd>] remove_watch_no_event+0x8d/0x100 Mar 27 14:38:18 server [<c01805f9>] inotify_ignore+0x49/0x90 Mar 27 14:38:18 server [<c018070d>] inotify_ioctl+0xcd/0x110 Mar 27 14:38:18 server [<c016ac26>] do_ioctl+0x76/0x90 Mar 27 14:38:18 server [<c016adb9>] vfs_ioctl+0x59/0x1c0 Mar 27 14:38:18 server [<c016af59>] sys_ioctl+0x39/0x60 Mar 27 14:38:18 server [<c0102f6b>] sysenter_past_esp+0x54/0x75 I've looked through the code and iput can usually be called after releasing spinlocks. It doesn't look trivial to implement though.
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- [patch] Re: inotify issue: iput called atomically
- From: Robert Love <[email protected]>
- [patch] Re: inotify issue: iput called atomically
- Prev by Date: [PATCH] fix module_param_string() calls
- Next by Date: Re: Can't use SYSFS for "Proprietry" driver modules !!!.
- Previous by thread: [PATCH] fix module_param_string() calls
- Next by thread: [patch] Re: inotify issue: iput called atomically
- Index(es):
 |