Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

> > It's impossible to be otherwise. A call requires
> > that the return address be written to memory (the stack),
> > using register indirection (the stack-pointer).
> 
> and it's a so common pattern that it's optimized to death. Internally a
> call gets transformed to 2 uops or so, one is push eip, the other is the
> jmp (which gets then just absorbed by the "what is the next eip" logic,
> just as a "jmp"s are 0 cycles)

Arjan, you overlook the fact that kfree() contains 'if(!p) return;' too.
call + test-and-branch can never be faster than test+and+branch.
Maybe on the really clever CPU it can take the same time, but not faster...
--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
    • From: Arjan van de Ven <[email protected]>

• References:
  • [PATCH] no need to check for NULL before calling kfree() - fs/ext2/
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
    • From: linux-os <[email protected]>
  • Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: Can't use SYSFS for "Proprietry" driver modules !!!.
• Next by Date: [PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set()
• Previous by thread: Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
• Next by thread: Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]