[2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c.old	2005-03-23 05:10:34.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c	2005-03-23 05:10:55.000000000 +0100
@@ -577,11 +577,11 @@ cpqhp_set_attention_status(struct contro
 {
 	u8 hp_slot;
 
-	hp_slot = func->device - ctrl->slot_device_offset;
-
 	if (func == NULL)
 		return(1);
 
+	hp_slot = func->device - ctrl->slot_device_offset;
+
 	// Wait for exclusive access to hardware
 	down(&ctrl->crit_sect);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use
    • From: Greg KH <[email protected]>

• Prev by Date: Re: [2.6 patch] drivers/input/serio/libps2.c: ps2_command: add a missing check
• Next by Date: Re: [PATCH 2.6.11.2][2/2] printk with anti-cluttering-feature
• Previous by thread: [PATCH 5/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS
• Next by thread: Re: [2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]