Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

We just send an update to Andrew and Jeff that also fixes this issue.
Sadly that patch is >300k so we cannot post it to the list.

On Thu, 24 Mar 2005, Adrian Bunk wrote:

> The #define MODVERSIONS doesn't make sense.
>
> And there's no need to #ifdef an #include <linux/module.h>.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h.old	2005-03-24 01:20:02.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h	2005-03-24 01:20:17.000000000 +0100
> @@ -33,13 +33,7 @@
>  #define __CHELSIO_OSDEP_H
>
>  #include <linux/version.h>
> -#if defined(MODULE) && ! defined(MODVERSIONS)
> -#define MODVERSIONS
> -#endif
> -#ifdef MODULE
>  #include <linux/module.h>
> -#endif
> -
>  #include <linux/config.h>
>  #include <linux/types.h>
>  #include <linux/delay.h>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups
    • From: "Randy.Dunlap" <[email protected]>

• References:
  • [-mm patch] drivers/net/chelsio/osdep.h: small cleanups
    • From: Adrian Bunk <[email protected]>

• Prev by Date: [2.6 patch] mm/filemap.c: make generic_file_direct_IO static
• Next by Date: [2.6 patch] drivers/net/arcnet/: possible cleanups
• Previous by thread: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups
• Next by thread: Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]